-
Notifications
You must be signed in to change notification settings - Fork 267
type: Track type of SpatialImage.affine, test type inference #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 95.35%. Comparing base (
84294f4) to head (f1f6cfe).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1411 +/- ## ========================================== + Coverage 95.34% 95.35% +0.01% ========================================== Files 208 209 +1 Lines 29772 29783 +11 Branches 3355 3353 -2 ========================================== + Hits 28385 28400 +15 + Misses 948 947 -1 + Partials 439 436 -3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@effigies
effigies
force-pushed
the
type/spatialimage-affines
branch
3 times, most recently
from
February 16, 2025 15:14
26dbefe to
67acfdc
Compare
This is ready to go. Reviews welcome, or else will merge on Thursday, Feb 20.
jhlegarreta
jhlegarreta
approved these changes
Mar 14, 2025
Improve type-checkers' ability to predict dtype
@effigies
effigies
force-pushed
the
type/spatialimage-affines
branch
from
March 14, 2025 21:42
67acfdc to
f1f6cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays some groundwork for further type annotations. The main thing it does is make
SpatialImagegeneric over its affine type, which can either beAffine(an alias for ndarray that might be refined in the future) orNone.This is a somewhat pedantic thing to track, as it is extremely rare not to provide an affine to an image, but there are cases where it is the correct thing to do. This allows for a forthcoming PR to annotate functions that require an affine or can accept an image with
Nonein it.It also introduces tests where we specifically test for what
mypysays the types of variables are, which lets us verify not only that our types are internally valid, but that they expose what we expect to downstream users.