Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

ENH: CoordinateImage API #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
effigies wants to merge 26 commits into nipy:master
base: master
Choose a base branch
Loading
from effigies:enh/coordimage_api
Draft

Conversation

Copy link
Member

@effigies effigies commented Feb 21, 2022

Along with #1084, replaces #1056.

Starting with some basic implementations in test directory. Next step is to write some API unit tests to clarify expected behavior and code some specific implementations toward those tests.

Will close #1056 once I've taken all comments into account.

Copy link

pep8speaks commented Feb 21, 2022 •
edited
Loading

Hello @effigies, Thank you for updating!

Line 34:1: F811 redefinition of unused 'Recoder' from line 33
Line 35:1: F811 redefinition of unused 'warn' from line 22

To test for issues locally, pip install flake8 and then run flake8 nibabel.

Comment last updated at 2022年08月31日 00:48:00 UTC

Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.81781% with 322 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (9d66d8a) to head (20f71df).

Files with missing lines Patch % Lines
nibabel/tests/test_pointset.py 21.19% 119 Missing ⚠️
nibabel/coordimage.py 25.00% 81 Missing ⚠️
nibabel/cifti2/caretspec.py 58.33% 41 Missing and 9 partials ⚠️
nibabel/tests/test_coordimage.py 13.46% 45 Missing ⚠️
nibabel/pointset.py 51.35% 18 Missing ⚠️
nibabel/cifti2/tests/test_caretspec.py 65.38% 9 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
- Coverage 95.34% 93.90% -1.44% 
==========================================
 Files 208 212 +4 
 Lines 29768 30259 +491 
 Branches 3355 3420 +65 
==========================================
+ Hits 28381 28415 +34 
- Misses 948 1397 +449 
- Partials 439 447 +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the enh/coordimage_api branch 6 times, most recently from ef81d35 to 23e34f9 Compare February 25, 2022 16:26
@effigies effigies force-pushed the enh/coordimage_api branch 2 times, most recently from e8f9280 to 82eb277 Compare September 20, 2023 17:59
@effigies effigies force-pushed the enh/coordimage_api branch 2 times, most recently from 862a0c4 to f0c6a6b Compare September 22, 2023 13:22
effigies and others added 18 commits September 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /