Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

insulin_concentration_compose #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Philoul wants to merge 10 commits into nightscout:compose
base: compose
Choose a base branch
Loading
from Philoul:Todo/insulin_concentration_compose

Conversation

@Philoul
Copy link
Contributor

@Philoul Philoul commented Jan 26, 2026
edited
Loading

I propose this new starting point (I started from a working branch, and reorganized all the modification on 8 commits, each modified file is within only one of these 8 commits).
1- Infrastructure and database (v32, iCfg, new Interfaces for PumpRate, PumpInsulin, uel update, ...)
2- Profile updates (dia removal, add iCfg management within EffectiveProfile, ...)
3- Infra Pump, PumpSync and Bolus (add the new Layer including PumpWithConcentration, ...)
4- Pump Driver migration (all modifications on Pump driver to manage profile, PumpInsulin... is grouped within this commit)
5- Algo APS, Iob/Cob an automation, new management of IOB calculation with iCfg included within boluses
6- Insulin Plugin refactoring (one single plugin, InsulinSwitchDialog and ConcentrationDialog to manage switches)
7- update of all remaining plugins, and user interface
8- one latest commit to fix all (I hope) tests (probably the biggest commit due to number of tests impacted)

This has been done to facilitate review by theme, hope it will help. So all these commits work together (I didn't try to build intermediate steps but it will probably failed due to all cross connections).

All my work has been done using your commit AS data flow as starting point.

  • my first rebase on IOB COB graph worked perfectly without any conflicts...
  • I propose to continue my work on this branch, and will rebase regularly on compose
    Feel free to comment ;-)

@Philoul Philoul changed the title (削除) Todo/insulin_concentration_compose (削除ここまで) (追記) insulin_concentration_compose (追記ここまで) Jan 26, 2026
@Philoul Philoul force-pushed the Todo/insulin_concentration_compose branch from 4463fa7 to 566fb2d Compare January 31, 2026 22:26
@Philoul Philoul force-pushed the Todo/insulin_concentration_compose branch from 566fb2d to 6bdc1ce Compare February 1, 2026 13:19
Copy link

sonarqubecloud bot commented Feb 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /