-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Diaconn G8: Add firmware 3.58+ support and fix sync issues #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+181
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix TBR/EB home screen sync issue by using pump response fields instead of pumpSync.expectedPumpState() which has timing issues - Add firmware 3.58+ BLE permanent connection support (skip disconnect) - Improve changePump() to detect actual device change by address comparison - Fix history record ordering (wrappingCount, lognum instead of timestamp) - Add BolusSpeed preference migration (Int to String) - Improve OTP wait loop (20 to 30 iterations with better logging)
Replace direct loadHistory() calls with commandQueue.loadEvents() to allow proper reconnection when needed. Also increase log inquiry message timeout from 500ms to 2000ms for reliability.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary