-
Notifications
You must be signed in to change notification settings - Fork 137
Add First Class OpenShift support #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.83%. Comparing base (6fc41cb) to head (0a0582f).
Additional details and impacted files
@@ Coverage Diff @@ ## main #4001 +/- ## ======================================= Coverage 86.82% 86.83% ======================================= Files 128 128 Lines 16607 16607 Branches 62 62 ======================================= + Hits 14419 14420 +1 + Misses 2006 2005 -1 Partials 182 182
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
4504014 to
28d8e3f
Compare
Add bundle, update RBAC, use root helm chart
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
8aff6fe to
0a0582f
Compare
Is this just a merge of the feature branch or were there any other additional changes?
Is this just a merge of the feature branch or were there any other additional changes?
@bjee19 Just the merge of the feature branch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Is this just a merge of the feature branch or were there any other additional changes?
The commits reflect the PRs that were reviewed and merged, if that helps makes review simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding the removing of GatewayStaticAddresses, do we have a system in place of running that test on main/edge when not trying to conform to 1.2.1 for openshift?
PR lgtm, as long as there is some plan moving forwards on that.
Uh oh!
There was an error while loading. Please reload this page.
Proposed changes
Problem: As a cluster operator managing traffic for an OpenShift cluster
I want easily deploy NGF as my Gateway API implementation from the Operator Hub
So that it is easier for me to try out and use NGF for my OpenShift environment.
Solution: Add UBI based images and an Operator so we can begin the RedHat Operator Certification process and get NGF into the RedHat Certified OperatorHub
Epic: #3668
Testing:
DRAFT UNTIL
(削除) #3989 (削除ここまで),(削除) #3980 (削除ここまで)and(削除) #4004 (削除ここまで)ARE MERGEDChecklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.