-
Notifications
You must be signed in to change notification settings - Fork 138
Add CEL validation tests for ObservabilityPolicy CRD
#3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.86%. Comparing base (0a3cb1a) to head (6404556).
Additional details and impacted files
@@ Coverage Diff @@ ## main #3735 +/- ## ======================================= Coverage 86.86% 86.86% ======================================= Files 128 128 Lines 16201 16201 Branches 62 62 ======================================= Hits 14073 14073 Misses 1954 1954 Partials 174 174
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a lot of these separate test functions could just be combined into one, to reduce duplication. They are ultimately formatted and testing very similar things. For example, 3 different test functions that are testing the TargetRef field. Could be one large list of structs in a single test IMO.
Uh oh!
There was an error while loading. Please reload this page.
Proposed changes
This change adds test for the CEL validation for the
ObservabilityPolicyCRCloses #3670
Checklist
Before creating a PR, run through this checklist and mark each as complete.