-
Notifications
You must be signed in to change notification settings - Fork 138
Fix NFR tests #3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix NFR tests #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-project-automation
github-project-automation
bot
added this to NGINX Gateway Fabric
Aug 12, 2025
@github-project-automation
github-project-automation
bot
moved this to 🆕 New
in NGINX Gateway Fabric
Aug 12, 2025
@github-actions
github-actions
bot
added
chore
Pull requests for routine tasks
tests
Pull requests that update tests
labels
Aug 12, 2025
salonichf5
salonichf5
approved these changes
Aug 12, 2025
sjberman
sjberman
approved these changes
Aug 12, 2025
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (1354b1d) to head (11fbc0d).
Additional details and impacted files
@@ Coverage Diff @@ ## main #3722 +/- ## ========================================== - Coverage 86.91% 86.91% -0.01% ========================================== Files 128 128 Lines 15962 15962 Branches 62 62 ========================================== - Hits 13874 13873 -1 Misses 1921 1921 - Partials 167 168 +1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@github-project-automation
github-project-automation
bot
moved this from 🆕 New
to ✅ Done
in NGINX Gateway Fabric
Aug 12, 2025
bjee19
added a commit
that referenced
this pull request
Aug 12, 2025
NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.
bjee19
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.