Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Chore: Use F5 artifactory GOPROXY and self-hosted runners #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciarams87 merged 14 commits into main from chore/secure-build-pipeline
Sep 4, 2025

Conversation

Copy link
Contributor

@ciarams87 ciarams87 commented Aug 11, 2025 •
edited
Loading

Proposed changes

  • Use F5 Artifactory goproxy for all CI runs that do not originate from forks
  • Use self hosted runners for jobs that produce artifacts
    • There are issues with enabling permissions on the runners for workflow runs originating from tags, so enabling this requires updating our release process to run from a manually triggered workflow instead of creating a tag.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.00%. Comparing base (81d3c43) to head (1b2a1b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@
## main #3718 +/- ##
=======================================
 Coverage 87.00% 87.00% 
=======================================
 Files 128 128 
 Lines 16434 16434 
 Branches 62 62 
=======================================
 Hits 14299 14299 
 Misses 1959 1959 
 Partials 176 176

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch from 07e7192 to 29d11db Compare August 20, 2025 13:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 20, 2025
@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch 3 times, most recently from 40a5d85 to 0ba8d33 Compare August 20, 2025 16:33
@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch from 2dbe1ff to 8e8ffe2 Compare August 25, 2025 12:44
@ciarams87 ciarams87 marked this pull request as ready for review August 25, 2025 13:13
@ciarams87 ciarams87 requested review from a team as code owners August 25, 2025 13:13
@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch from a6e7e68 to be95f7e Compare August 27, 2025 09:39
@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch 2 times, most recently from 922e3bd to 0df4c1e Compare August 29, 2025 08:01
@ciarams87 ciarams87 force-pushed the chore/secure-build-pipeline branch from 0df4c1e to 8de73b9 Compare September 2, 2025 08:19
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after single comment i left on another resolved comment

@ciarams87 ciarams87 enabled auto-merge (squash) September 4, 2025 09:48
@ciarams87 ciarams87 enabled auto-merge (squash) September 4, 2025 09:48
@ciarams87 ciarams87 merged commit 9406f12 into main Sep 4, 2025
44 checks passed
@ciarams87 ciarams87 deleted the chore/secure-build-pipeline branch September 4, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@pdabelf5 pdabelf5 Awaiting requested review from pdabelf5

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /