-
Notifications
You must be signed in to change notification settings - Fork 138
Add mirroring fraction edge case test #3708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bjee19 please take a look if I missed and you already have it
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.03%. Comparing base (385d5be) to head (501f496).
Additional details and impacted files
@@ Coverage Diff @@ ## main #3708 +/- ## ========================================== + Coverage 87.00% 87.03% +0.02% ========================================== Files 128 128 Lines 15919 15919 Branches 62 62 ========================================== + Hits 13851 13855 +4 + Misses 1902 1899 -3 + Partials 166 165 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice catch
Proposed changes
Noticed that there is no test for mirroring with Faction setting when Denominator=Numerator, when we get 100% mirroring
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes