-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Conversation
@erinzm
erinzm
force-pushed
the
app-exception-handling
branch
from
June 16, 2017 17:45
2926e16 to
33c09e3
Compare
@erinzm
erinzm
force-pushed
the
app-exception-handling
branch
from
June 16, 2017 17:45
33c09e3 to
eb7bef4
Compare
lalitkumarj
commented
Jul 10, 2017
Member
I don't understand, why were the try except blocks pulled out? This was the only good way of bubbling app level exceptions up to the user through the api?
Author
@lalitkumarj The try-except blocks had essentially duplicated code in each, so the exception handling was moved into tasks.py, where each of the app functions is called.
This is done by wrapping every call to an app function in this decorator, which performs the same error checking/logging as the original blocks.
lalitkumarj
commented
Jul 10, 2017
via email
Member
Just to make sure, this propagates back to the user right (ie you get an
error as a response to the api call?).
Lalit
... On Mon, Jul 10, 2017 at 11:42 AM, Liam Marshall ***@***.***> wrote:
@lalitkumarj <https://github.com/lalitkumarj> The try-except blocks had
virtually duplicated code in each, so the exception handling was moved into
tasks.py, where each of the app functions is called.
This is done by wrapping every call to an app function in this decorator
<https://github.com/nextml/NEXT/pull/192/files#diff-5806b38ec37128c1df1ceecced84a9d9R42>,
which performs the same error checking/logging as the original blocks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#192 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABWhGBgBcy_Rt-7HaWxpASQ61n7vHJkUks5sMkZygaJpZM4N7gea>
.
@erinzm
erinzm
changed the title
(削除) Clean up App exception handling (削除ここまで)
(追記) Clean up App exception handling [WIP] (追記ここまで)
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.