Skip to content

Navigation Menu

Sign in
Sign up

Add better error handling - #84

Merged
MorrisJobke merged 1 commit into
master from
enable-debug-mode-if-instance-wide-debug-mode-is-enabled
Feb 3, 2017
Merged

Add better error handling #84
MorrisJobke merged 1 commit into
master from
enable-debug-mode-if-instance-wide-debug-mode-is-enabled

Conversation

@LukasReschke

@LukasReschke LukasReschke commented Feb 3, 2017

Copy link
Copy Markdown
Member
  1. Enable debug mode if debug mode is enabled in config.php
  2. Log errors to the log file

Also I fixed the unit tests that broke with #81

Signed-off-by: Lukas Reschke lukas@statuscode.ch

1. Enable `debug` mode if debug mode is enabled in config.php
2. Log errors to the log file
Also I fixed the unit tests that broke with #81
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

codecov-io commented Feb 3, 2017
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@c96b0c1). Click here to learn what that means.

@@ Coverage Diff @@
## master #84 +/- ##
========================================
 Coverage ? 36.8% 
 Complexity ? 98 
========================================
 Files ? 10 
 Lines ? 413 
 Branches ? 0 
========================================
 Hits ? 152 
 Misses ? 261 
 Partials ? 0
Impacted Files Coverage Δ Complexity Δ
lib/samlsettings.php 0% <ø> (ø) 18 <ø> (?)
lib/Settings/Section.php 100% <100%> (ø) 5 <1> (?)
lib/Controller/SAMLController.php 51.13% <25%> (ø) 25 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96b0c1...29c60c3. Read the comment docs.

MorrisJobke merged commit c7dfbf2 into master Feb 3, 2017
MorrisJobke deleted the enable-debug-mode-if-instance-wide-debug-mode-is-enabled branch February 3, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /