🗃️ Make archiving tables/applications a personal option - #2476

@jancborchardt jancborchardt left a comment •

edited by AndyScherzinger

Loading

Setting the parameter inside the loop preventing rebuilding the query representation if this really loops a lot.
Co-authored-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

...ust getXXX
Co-authored-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AI-assistant: Claude Code 2.1.119 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>

The middleware only recognizes contexts when the type arrives as the
string 'context'; an integer NODE_TYPE_CONTEXT is rejected as an
invalid node type before the controller runs.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

TableService::find() returns the entity-level archived flag; use
getTableForUser() so GET /tables/{id} reflects the requesting user's
personal archive override.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Resolve the per-user archive state for nav-bar contexts and skip
archived ones so archiving an application also declutters the global
navigation.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

The migration was created in April under version 2020 and would sort
before migrations already released on main (2200-2210); rename it to
2400 with a current date stamp.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Replace hardcoded node type 0 with Application::NODE_TYPE_TABLE.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Prepare the share lookup and the archive check/insert queries a single
time and rebind their parameters per iteration instead of recreating
query builders for every archived table and recipient.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Replace the read-modify-write cycle with IDBConnection::setValues(),
which is portable across all supported databases and closes the race
between concurrent requests hitting the unique index.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

The method had no production caller; tests now verify row counts with
a direct count query instead.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Extract the shared load-overrides-and-merge logic of the table and
context enrichment methods into one private helper.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

...r archive test
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

...ler archive test
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Return early when the archived table or application is no longer in
the local store instead of dereferencing undefined.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Vue 3 proxy reactivity tracks array index assignment, so the splice
swap is unnecessary; drop the unrelated change.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Align the archived-applications counter with the archived-tables one,
which already uses the count prop introduced with nextcloud/vue 9.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Wrap the ArchiveService calls in the same OCP\DB\Exception-to-
InternalError conversion TableService uses so tables and contexts
report archive failures consistently.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

...access
An ownership transfer preserved the outgoing owner's archive view with
a personal override even when they lose access to the node entirely,
leaving orphaned rows in tables_archive_user. Remove the override
inside the transfer transaction when the outgoing owner can no longer
read the table or access the context.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

tables_shares stores node_type as a string ('table'), so filtering with
the integer NODE_TYPE_TABLE constant never matched the direct user
shares (or, on MySQL loose casting, matched every node type). Recipient
archive records were therefore not migrated correctly.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Add UserArchiveMapper::findUserIdsForNode() and deleteAllForUser(),
plus ShareMapper::findNodesByReceiver(), as building blocks for
cleaning up per-user archive overrides when access is lost.
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Follow the pattern established by server group shares and the circles
app: shares stay group/circle-targeted with dynamic access resolution,
and only the materialized per-user state is removed once membership or
sharing ends. The new ArchiveCleanupService drops a user's archive
override after verifying they no longer have access to the node, and is
triggered when
- a user is removed from a group (UserRemovedEvent),
- a member is removed from a circle (CircleMemberRemovedEvent,
 including inherited members of a removed nested circle),
- a group is deleted or a circle destroyed (the existing receiver
 cleanup now also purges stale overrides on the affected nodes),
- a share is deleted (single receiver check for user shares, full node
 purge for group and circle shares),
- a user account is deleted (all overrides of that user are removed).
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

The v1 updateTable endpoint defaulted the archived parameter to false
instead of null, and the tables:update occ command declared the
--archived option as VALUE_NONE, which resolves to false when omitted.
Both callers therefore passed an explicit unarchive on every partial
update, silently resetting the archived state of a table on a plain
title or emoji change.
Default both to null so an omitted parameter leaves the state unchanged;
the occ option becomes negatable (--archived / --no-archived).
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>