Skip to content

Navigation Menu

Sign in
Sign up

Fix: Properly display removed options in selection columns - #2450

Open
Koc wants to merge 1 commit into
main from
bugfix/fix-displaying-removed-options
Open

Fix: Properly display removed options in selection columns #2450
Koc wants to merge 1 commit into
main from
bugfix/fix-displaying-removed-options

Conversation

@Koc

@Koc Koc commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reproducer

  1. Create a table with select and multi select columns
  2. Create rows, select values
  3. Remove some options

Expected result

We should see yellow triangle with exclamation mark that informs us about non-existent optipns

🖼️ Screenshoots

➖ Before ➕ After
image image

Koc force-pushed the bugfix/fix-displaying-removed-options branch 5 times, most recently from 22960ea to d7f542a Compare April 6, 2026 11:37
Koc marked this pull request as ready for review April 6, 2026 11:38
Koc requested review from blizzz and enjeck as code owners April 6, 2026 11:38
Koc force-pushed the bugfix/fix-displaying-removed-options branch from d7f542a to 0d781c4 Compare April 10, 2026 21:22

enjeck commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Related to #727

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If deleting an option is supposed to actually remove that value from rows, then the best UX in my opinion is to reflect that cleanup directly: remaining selections stay visible, deleted ones disappear. I don't like keeping a ghost value around.

Koc force-pushed the bugfix/fix-displaying-removed-options branch from 0d781c4 to 4aa1855 Compare April 12, 2026 21:29
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Apr 12, 2026
enjeck force-pushed the bugfix/fix-displaying-removed-options branch from 4aa1855 to 65afdf2 Compare June 16, 2026 05:22

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments:

<div class="cell-selection">
<div v-if="!isEditing" class="non-edit-mode" @click="handleStartEditing">
{{ column.getLabel(value) }}<span v-if="isDeleted()" :title="t('tables', 'This option is outdated.')">&nbsp;⚠️</span>
<template v-if="selectedOption.deleted">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this throws an error if you:

  1. Open a table that has rows.
  2. Add a new single-selection column with no default value (or just leave any existing single-select cell empty).
  3. View the table in grid mode.
TypeError: Cannot read properties of null (reading 'deleted')
 at VueComponent.render50 (TableCellSelection.vue:158:1)

Easy fix could be:

Suggested change
<template v-if="selectedOption.deleted">
<template v-if="selectedOption?.deleted">

Comment on lines 22 to +23
getLabel(id) {
const i = this.selectionOptions?.findIndex((obj) => obj.id === id)
return this.selectionOptions[i]?.label
return this.getOptionObject(id)?.label

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLabel now returns String(id) instead of undefined for orphaned values, which changes filter behavior in isFilterFound. i suppose that for example, IsEmpty there will now treat a row holding a deleted option as non-empty? Same for Contains, BeginsWith etc
Is this intentional behavior?

 

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
enjeck force-pushed the bugfix/fix-displaying-removed-options branch from 65afdf2 to 283b6fd Compare August 27, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck enjeck left review comments
@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /