refactor(updatenotification): remove unused notifier mock branch - #64160

Open

joshtrichards wants to merge 2 commits into

master from

jtr/refactor-notTest

Open

refactor(updatenotification): remove unused notifier mock branch #64160
joshtrichards wants to merge 2 commits into
master from
jtr/refactor-notTest

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Sep 10, 2026 •

edited

Loading

Copy link

Copy Markdown

Member

~~(削除) Resolves: # (削除ここまで)~~

Summary

The test helper is only called without method overrides, so remove the unused partial-mock path and simplify its signature and return type.
Replace manual try/catch assertions with PHPUnit's expectException() API and split successful and exceptional cases into focused tests.

TODO

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

joshtrichards added 2 commits

September 9, 2026 20:05

@joshtrichards


 refactor(updatenotification): remove unused notifier mock branch

The test helper is only called without method overrides, so remove the unused partial-mock path and simplify its signature and return type.
Signed-off-by: Josh <josh.t.richards@gmail.com>

@joshtrichards


 test(updatenotification): use PHPUnit exception expectations

63645a5

Replace manual try/catch assertions with PHPUnit's expectException() API and split successful and exceptional cases into focused tests.
Assisted-by: Copilot:gpt-5.6-luna
Signed-off-by: Josh <josh.t.richards@gmail.com>

@nextcloud-command nextcloud-command added the AI assisted label

Sep 10, 2026