Skip to content

Navigation Menu

Sign in
Sign up

[stable33] fix(files_sharing): don't abort share:list when orphaned shares exist - #64147

Open
backportbot[bot] wants to merge 1 commit into
stable33 from
backport/62060/stable33
Open

[stable33] fix(files_sharing): don't abort share:list when orphaned shares exist #64147
backportbot[bot] wants to merge 1 commit into
stable33 from
backport/62060/stable33

Conversation

@backportbot

@backportbot backportbot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Backport of PR #62060

`occ share:list` resolved the source node of every share without
handling NotFoundException, so a single orphaned share (e.g. the source
file was deleted from disk externally, or is pending removal by
DeleteOrphanedSharesJob) aborted the whole command with "Node for share
not found" and produced no output at all.
Catch the exception in both places that resolve the share node: orphaned
shares are now listed with a null source-path, and the --parent filter
skips them instead of crashing.
Add unit tests for the command (previously untested), covering listing
with an orphaned share present and the --parent filter with and without
--recursive.
Closes #61949
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes
@provokateurin provokateurin provokateurin approved these changes
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /