Skip to content

Navigation Menu

Sign in
Sign up

[stable32] fix(files_sharing): don't abort share:list when orphaned shares exist - #64145

Open
backportbot[bot] wants to merge 1 commit into
stable32 from
backport/62060/stable32
Open

[stable32] fix(files_sharing): don't abort share:list when orphaned shares exist #64145
backportbot[bot] wants to merge 1 commit into
stable32 from
backport/62060/stable32

Conversation

@backportbot

@backportbot backportbot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Backport of PR #62060

`occ share:list` resolved the source node of every share without
handling NotFoundException, so a single orphaned share (e.g. the source
file was deleted from disk externally, or is pending removal by
DeleteOrphanedSharesJob) aborted the whole command with "Node for share
not found" and produced no output at all.
Catch the exception in both places that resolve the share node: orphaned
shares are now listed with a null source-path, and the --parent filter
skips them instead of crashing.
Add unit tests for the command (previously untested), covering listing
with an orphaned share present and the --parent filter with and without
--recursive.
Closes #61949
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
@blizzz blizzz removed this from the Nextcloud 32.0.15 milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /