Skip to content

Navigation Menu

Sign in
Sign up

[stable34] fix(files_sharing): normalize share target on parent folder rename - #64143

Open
backportbot[bot] wants to merge 4 commits into
stable34 from
backport/64122/stable34
Open

[stable34] fix(files_sharing): normalize share target on parent folder rename #64143
backportbot[bot] wants to merge 4 commits into
stable34 from
backport/64122/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Sep 9, 2026
edited
Loading

Copy link
Copy Markdown

Backport of #64122

Todo

  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

silverkszlo and others added 4 commits September 9, 2026 12:16
When a recipient moved an incoming share into one of their own folders
and later renamed that folder, Updater::renameChildren passed the mount
point to SharedMount::moveMount. Mount points always end in a slash, and
stripUserFilesPath did not normalize its result, so the slash was stored
in share.file_target. PROPFIND on such a share then returns 500.
Normalize the stripped path so no caller can write a trailing slash, and
repair rows that are already affected.
Signed-off-by: silver <s.szmajduch@posteo.de>
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
perf(core): only run the trailing slash share repair once
Signed-off-by: silver <s.szmajduch@posteo.de>
Assisted-by: ClaudeCode:claude-opus-5
[skip ci]
backportbot Bot requested a review from a team as a code owner September 9, 2026 12:16
backportbot Bot requested review from come-nc, icewind1991, provokateurin, salmart-dev, silverkszlo and susnux and removed request for a team September 9, 2026 12:16
@backportbot backportbot Bot added this to the Nextcloud 34.0.4 milestone Sep 9, 2026
@github-actions github-actions Bot changed the title (削除) [stable34] [stable35] fix(files_sharing): normalize share target on parent folder rename (削除ここまで) (追記) [stable34] fix(files_sharing): normalize share target on parent folder rename (追記ここまで) Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@silverkszlo silverkszlo silverkszlo approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /