-
Notifications
You must be signed in to change notification settings - Fork 106
feat(teamspace): resolve teams for files inside a team folder - #5035
Draft
pringelmann wants to merge 1 commit into
Draft
feat(teamspace): resolve teams for files inside a team folder #5035pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
pringelmann
force-pushed
the
feat/team-folder-teams-reverse-lookup
branch
from
August 21, 2026 09:04
c403272 to
7b378cf
Compare
Draft
9 tasks
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
feat/team-folder-teams-reverse-lookup
branch
from
August 21, 2026 09:29
7b378cf to
3fa9325
Compare
pringelmann
marked this pull request as ready for review
August 21, 2026 16:00
pringelmann
marked this pull request as draft
August 21, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Open a team folder in Files and the sidebar shows no team. Same for files inside it. The sidebar asks the files provider, which finds teams from share rows, and a team folder arrives as a mount so there is never a row.
TeamSpaceProvidernow implementsITeamFileResolverfrom nextcloud/server#63444. Given a file id it looks up the mount the file lives in and the group folder behind it, then returns that folder's teams.getTeamsForResource, which returned nothing before, now answers for a folder id, which is what the Teams UI sends.Tested at the mount root, two levels deep, on a team-shared folder, and on an unrelated file:
imageDepends on nextcloud/server#63444. CI fails until that merges and
nextcloud/ocpsyncs.