fix(gradle): Fixed broken handling of test server and credentials #16422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

PhilLab wants to merge 1 commit into master

Open

PhilLab wants to merge 1 commit into master from ph/fix_build_arguments

+3 −3

Conversation

Copy link

Contributor

This was a refactoring error from a17e138

@PhilLab PhilLab requested a review from tobiasKaminsky


 fix(gradle): Fixed broken handling of test server and credentials

d4fecd9

This was a refactoring error from a17e138
Signed-off-by: Philipp Hasper <vcs@hasper.info>

Copy link

Contributor Author

For what its worth, I also had other build troubles caused by the Gradle update, but I didn't include them in the PR here, because their solution is less obvious: App build fails in encrypted Linux home dir since upgrade to AGP 9 #16421
I am not exactly sure what it means that the PR I am hereby amending: chore(agp): Android Gradle plugin 9.0.0 #16306 , was added to the 3.36.0 milestone. Maybe the fix here should be in the milestone as well, if this is required to be part of the release code.

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16422.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.