Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(share): icons #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alperozturk96 wants to merge 4 commits into master
base: master
Choose a base branch
Loading
from fix/share-icons
Open

fix(share): icons #16418

alperozturk96 wants to merge 4 commits into master from fix/share-icons

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 30, 2026 •
edited
Loading

  • Tests written, or not not needed

Fixes

Share internal link alignment
Dropdown icon visibility (only visible if permission name exists)
Converts image views to material icon button since they are button not icon

Before Internal Dark After Internal Dark
before after
Before Internal Light After Internal Light
before after
Before External Light After External Light
before after
Before External Dark After External Dark
before after 

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16418.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Member

@alperozturk96 What is the webUI displaying? Is it also hiding the element or are we missing something on the client-side?

Copy link
Member

@alperozturk96 the icon colors changed, but didn't yet check what M3 would define for icon-only buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@kra-mo kra-mo Awaiting requested review from kra-mo

@mpivchev mpivchev Awaiting requested review from mpivchev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share icons circle backgrounds are cut off, or inside icons are too large

AltStyle によって変換されたページ (->オリジナル) /