-
Notifications
You must be signed in to change notification settings - Fork 72
fix(stream): drop deprecated word-break keyword failing stylelint - #2906
Open
solracsf wants to merge 1 commit into
Open
fix(stream): drop deprecated word-break keyword failing stylelint #2906solracsf wants to merge 1 commit into
solracsf wants to merge 1 commit into
Conversation
`declaration-property-value-keyword-no-deprecated` reports `word-break: break-word` as an error rather than a warning, so `npm run stylelint` exits 2 and the stylelint job, which runs on every pull request with no path filter, fails. The declaration was redundant anyway: the same rule already sets `overflow-wrap: break-word` on the line above, which is what the legacy keyword aliases to. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
npm run stylelintcurrently exits 2 on master, so the stylelint job fails on every pull request — it runs onpull_requestwith no path filter.declaration-property-value-keyword-no-deprecatedreportsword-break: break-wordas an error, not a warning.The declaration was redundant anyway: the same rule already sets
overflow-wrap: break-wordon the line above, which is what the legacy keyword aliases to. Removing it takes the run to 0 errors, 20 warnings, exit 0.