-
-
Notifications
You must be signed in to change notification settings - Fork 88
Comments
Implemented RFC 7239 - "Forwarded HTTP Extension"#94
Implemented RFC 7239 - "Forwarded HTTP Extension" #94dg merged 8 commits intonette:master from patrickkusebauch:master
Conversation
src/Http/RequestFactory.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work with IPv6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPv6 support in commit 11461e6
Will now work with IPv6. Added tests for port and scheme of the URL
- Split test into "x-forwarded" and "forwarded" files for proxy - Added tests for default scheme. - Added tests for every combination of IPv4/IPv6 with and without port for both "host" and "for" headers
JanTvrdik
commented
May 22, 2016
possible related #92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simplified to
foreach ($forwardParams as $forwardParam) { list($key, $value) = explode('=', $forwardParam, 2) + [1 => NULL]; $proxyParams[strtolower(trim($key))] = trim($value, "\t\""); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrated in commit a2c7a79
patrickkusebauch
commented
May 22, 2016
I know that it keeps failing on php5.6 with composer update --no-interaction --prefer-dist --prefer-lowest --prefer-stable. However this cannot be redeemed as the tests have to change to keep up with the versions. Furthermore they are test unrelated to this pull request.
patrickkusebauch
commented
May 23, 2016
Any other problems to be fixed with this PR?
Missing tests?
Or can I safely squash it to be merged?
dg
commented
Jun 17, 2016
Is it ready for merge?
patrickkusebauch
commented
Jun 17, 2016
Since there were no comments to the PR for more than 3 weeks, I would assume nobody has any more problems with it.
So yes, it is ready for merge.
dg
commented
Jun 17, 2016
So thanks!
patrickkusebauch
commented
Jun 17, 2016
I thank you for letting me be a part of the development of Nette. :)
* Implemented RFC 7239 - " Forwarded HTTP Extension" handling in RequestFactory * Implemented RFC 7239 - " Forwarded HTTP Extension" handling in RequestFactory * Deleted echo statement * case- insensitive handling of tokens * Proper handle of quoted strings. Will now work with IPv6. Added tests for port and scheme of the URL [Closes #94] * Tests refactoring: - Split test into "x-forwarded" and "forwarded" files for proxy - Added tests for default scheme. - Added tests for every combination of IPv4/IPv6 with and without port for both "host" and "for" headers * Code simplifications * Fixed coding standards for tests
Uh oh!
There was an error while loading. Please reload this page.
RequestFactory can now take "RemoteAddress", "RemoteHost", "port" and "scheme" from the proxy "FORWARDED" header.