-
-
Notifications
You must be signed in to change notification settings - Fork 88
Comments
Open
Conversation
Contributor
JanTvrdik
commented
Dec 27, 2014
👍 This is exactly what I had in mind. Now we just need to figure out how to handle the invalid request 😄
Partially related to it – what should RequestFactory do when running in CLI? Because that is another form of invalid URL (or HTTP request in general).
You can remove the Strings::fixEncoding now as well.
@dg
dg
force-pushed
the
master
branch
2 times, most recently
from
February 9, 2015 23:14
6df6a37 to
f17b437
Compare
@dg
dg
force-pushed
the
pull-invalid
branch
3 times, most recently
from
June 19, 2015 17:03
a2644ca to
e76600e
Compare
@dg
dg
force-pushed
the
master
branch
7 times, most recently
from
November 5, 2015 00:41
1dc599c to
f35d20f
Compare
@dg
dg
force-pushed
the
master
branch
2 times, most recently
from
July 21, 2016 12:07
7981e33 to
3fb64f5
Compare
@dg
dg
force-pushed
the
master
branch
3 times, most recently
from
December 20, 2016 14:30
b9f06ea to
4f6d6c9
Compare
@dg
dg
force-pushed
the
master
branch
5 times, most recently
from
December 11, 2023 13:01
55488bd to
2042d2e
Compare
@dg
dg
force-pushed
the
master
branch
2 times, most recently
from
May 2, 2024 10:56
4960652 to
5e67add
Compare
@dg
dg
force-pushed
the
master
branch
5 times, most recently
from
November 5, 2024 06:45
689f4ae to
33aae19
Compare
@dg
dg
force-pushed
the
master
branch
4 times, most recently
from
January 16, 2025 04:45
09923de to
02ae846
Compare
@dg
dg
force-pushed
the
master
branch
7 times, most recently
from
December 30, 2025 00:44
dc02250 to
80e8e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #30