Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

unescape optimized#38

Merged
dg merged 2 commits intonette:master from
dg:pull-unescape
Dec 21, 2014
Merged

unescape optimized #38
dg merged 2 commits intonette:master from
dg:pull-unescape

Conversation

@dg
Copy link
Member

@dg dg commented Dec 21, 2014

Closes #32

Copy link
Contributor

Nice! The following seems to have slightly better worse-case:

preg_replace_callback(
 '#(%(?:' . substr(chunk_split(bin2hex($reserved), 2, '|'), 0, -1) . '))++#i',
 function($m) {
 return rawurlencode(strtoupper($m[0]));
 },
 $s
);

On the other hand – its slower for common inputs so probably not worth it.

@dg
Copy link
Member Author

dg commented Dec 21, 2014

Reserved characters are rare, so probably not.

dg added a commit that referenced this pull request Dec 21, 2014
@dg dg merged commit cdfd0ab into nette:master Dec 21, 2014
@dg dg deleted the pull-unescape branch December 21, 2014 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /