-
-
Notifications
You must be signed in to change notification settings - Fork 88
Comments
Conversation
hrach
commented
Dec 17, 2014
+1 never used it.
JanTvrdik
commented
Dec 17, 2014
I also did not manage to find a server where $_SERVER['SCRIPT_NAME'] would be undefined.
JanTvrdik
commented
Dec 18, 2014
@dg Can I remove the URL filters? They are magical and people who know about them prefer to turn them off anyway – see http://forum.nette.org/cs/9903-ne-kanonizace-lomitek-v-url or https://twitter.com/JanTvrdik/status/542389794085404673 Or does it fall into the same category as binary mode?
dg
commented
Dec 20, 2014
ad $_SERVER['ORIG_PATH_INFO'] & $_SERVER['SCRIPT_NAME']: detection is magic. See this versus this. Currently it somehow works and it is better to not touch it ;-)
ad filters: their problem is that they do not work with canonicalization... Filters are not used because nobody knows about them, they are hard to set, but they are useful. For example, they fix bad url parsers (like this), so it would be better to figure out how to solve the canonicalization.
...PT_FILENAME (BC break) see #31 Conflicts: src/Http/RequestFactory.php
dg
commented
Dec 27, 2014
Partially merged by 37971f0
e6f0643 to
d6d5cc2
Compare
JanTvrdik
commented
Dec 27, 2014
ad filters: I'm aware of what they can do, I'm just saying that nobody is using them for that. Even your websites don't use them. Wouldn't it be better to handle those use-cases in routing instead of RequestFactory? Or not handle them at all?
0bb4336 to
96b498c
Compare
6df6a37 to
f17b437
Compare
f3ed3a1 to
f09472f
Compare
55488bd to
2042d2e
Compare
4960652 to
5e67add
Compare
689f4ae to
33aae19
Compare
09923de to
02ae846
Compare
dc02250 to
80e8e2b
Compare
$_SERVER['ORIG_PATH_INFO']because I don't know any HTTP server used in real-world which would actually require this