-
-
Notifications
You must be signed in to change notification settings - Fork 115
Comments
Open
Conversation
Member
dg
commented
Jan 15, 2021
What is the interface for? Replace it with your own implementation.
Contributor
Author
PavelJurasek
commented
Jan 19, 2021
Right, I can change service application.linkGenerator to whatever class I want, but it won't solve the problem with 3rd party packages that are typehinted to Nette\Application\LinkGenerator. That leads me to conclusion, that the PR should be reworked to:
- create ILinkGenerator interface
- create alias LinkGenerator for ILinkGenerator to keep BC
- rename current class implementation,
DefaultLinkGeneratoror similar
@PavelJurasek
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:13
b901a27 to
6739750
Compare
Member
dg
commented
Jan 19, 2021
@PavelJurasek I'll save this as a beautiful argument when someone wonders why I'm removing the letter I from the interface names. :-)
@PavelJurasek
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:52
f230978 to
febdc2b
Compare
@PavelJurasek
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:57
febdc2b to
2f18bdc
Compare
@dg
dg
force-pushed
the
master
branch
6 times, most recently
from
January 26, 2021 21:24
13f5ab3 to
c15bd94
Compare
@dg
dg
force-pushed
the
master
branch
9 times, most recently
from
February 8, 2021 05:57
7de5809 to
f817a0b
Compare
@dg
dg
force-pushed
the
master
branch
3 times, most recently
from
June 19, 2025 16:47
3463b9a to
ee24f8e
Compare
@dg
dg
force-pushed
the
master
branch
4 times, most recently
from
July 17, 2025 22:42
ddf16b5 to
87e4597
Compare
@dg
dg
force-pushed
the
master
branch
10 times, most recently
from
November 30, 2025 23:13
c62f26c to
e72b735
Compare
@dg
dg
force-pushed
the
master
branch
3 times, most recently
from
December 23, 2025 22:32
f536135 to
4e8f41d
Compare
@dg
dg
force-pushed
the
master
branch
2 times, most recently
from
December 28, 2025 23:56
c478b71 to
44181e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since LinkGenerator is final, it would be nice if it had its own interface so that it can be replaced with own implementation.