Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Comments

LinkGenerator: allow semicolon destination prefix#256

Open
dakujem wants to merge 25 commits intonette:master from
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator
Open

LinkGenerator: allow semicolon destination prefix #256
dakujem wants to merge 25 commits intonette:master from
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator

Conversation

@dakujem
Copy link

@dakujem dakujem commented Mar 24, 2020

Allows passing semicolon-prefixed destinations to LinkGenerator::link calls:

(new LinkGenerator(...))->link(':Foo:Bar:baz');
(new LinkGenerator(...))->link(':Bar:baz');
// and also this:
(new LinkGenerator(...))->link($presenter->getAction(true));

--
closes #255

@dg dg force-pushed the master branch 3 times, most recently from e23d6da to 22d5246 Compare March 25, 2020 10:45
@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from 4d7947a to 82ad558 Compare March 25, 2020 17:09
Copy link
Author

dakujem commented Mar 25, 2020

@dg I'd be grateful if this was merged & released promptly. It would be awesome. I see praparations for next release. This should be fully compatible.

@dg dg force-pushed the master branch 11 times, most recently from 4aeacfd to 06a6513 Compare April 2, 2020 00:57
@dg dg force-pushed the master branch 3 times, most recently from 3b21865 to 548c1db Compare April 20, 2020 21:58
@dg dg force-pushed the master branch 3 times, most recently from 18efdae to 3f51018 Compare May 11, 2020 22:55
Copy link
Author

dakujem commented May 20, 2020

Should I rebase this? Any plan to fix the issue?

@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from 82ad558 to b293b75 Compare May 20, 2020 19:17
Copy link
Author

dakujem commented May 20, 2020

You should update your test config - PHP 7.1 is no longer your target.

@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from b293b75 to 6f03449 Compare May 28, 2020 12:52
@dg dg force-pushed the master branch 2 times, most recently from ef333e6 to 9d529b4 Compare June 9, 2020 12:55
@dg dg force-pushed the master branch 3 times, most recently from 3463b9a to ee24f8e Compare June 19, 2025 16:47
@dg dg force-pushed the master branch 4 times, most recently from ddf16b5 to 87e4597 Compare July 17, 2025 22:42
@dg dg force-pushed the master branch 10 times, most recently from c62f26c to e72b735 Compare November 30, 2025 23:13
@dg dg force-pushed the master branch 3 times, most recently from f536135 to 4e8f41d Compare December 23, 2025 22:32
@dg dg force-pushed the master branch 2 times, most recently from c478b71 to 44181e2 Compare December 28, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsupported semicolon prefix in LinkGenerator::link calls

AltStyle によって変換されたページ (->オリジナル) /