Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Presenter::$layout can be either string or null#233

Open
mabar wants to merge 1 commit intonette:master from
mabar:patch-3
Open

Presenter::$layout can be either string or null #233
mabar wants to merge 1 commit intonette:master from
mabar:patch-3

Conversation

@mabar
Copy link
Contributor

@mabar mabar commented Sep 19, 2019
edited
Loading

  • bug fix? yes
  • BC break? no

It was not really string|bool but string|false|null, which kinda surprised me when I was implementing own layout finder

This variant is the only one I found which simplifies problem and does not break default implementation. Not sure about custom ones.

Alternative variant is change of annotation to string|false|null, but it's ugly.

@dg dg added this to the v3.1 milestone Sep 24, 2019
@dg dg force-pushed the master branch 7 times, most recently from 7e42997 to f7df426 Compare October 21, 2019 19:23
@dg dg force-pushed the master branch 4 times, most recently from 0e26720 to e65cf05 Compare November 19, 2019 19:03
@dg dg force-pushed the master branch 3 times, most recently from 7fe78c1 to 8f1bb54 Compare December 11, 2019 19:32
@dg dg force-pushed the master branch 13 times, most recently from c8eff84 to 447af2d Compare January 6, 2020 12:28
@dg dg force-pushed the master branch 3 times, most recently from 3463b9a to ee24f8e Compare June 19, 2025 16:47
@dg dg force-pushed the master branch 4 times, most recently from ddf16b5 to 87e4597 Compare July 17, 2025 22:42
@dg dg force-pushed the master branch 10 times, most recently from c62f26c to e72b735 Compare November 30, 2025 23:13
@dg dg force-pushed the master branch 3 times, most recently from f536135 to 4e8f41d Compare December 23, 2025 22:32
@dg dg force-pushed the master branch 2 times, most recently from c478b71 to 44181e2 Compare December 28, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /