feat!: disallow setting an object as a stream #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eduardoboucas merged 1 commit into main from feat/disallow-stream

Nov 9, 2023

Merged

feat!: disallow setting an object as a stream #96

eduardoboucas merged 1 commit into main from feat/disallow-stream

Nov 9, 2023

Conversation

eduardoboucas

Copy link

Member

@eduardoboucas eduardoboucas commented Nov 9, 2023 •

edited

Loading

Which problem is this pull request solving?

S3 doesn't support uploads with transfer-encoding: chunked, so we can't really accept a stream as the input to a set() call without buffering the data in the client.

Removing this option for now until we have a better solution.

Part of https://github.com/netlify/pillar-runtime/issues/775.

@eduardoboucas


 feat!: disallow setting an object as a stream

4fe2323

@eduardoboucas eduardoboucas requested a review from a team as a code owner

November 9, 2023 10:10

@netlify Netlify

Copy link

netlify bot commented Nov 9, 2023 •

edited

Loading

✅ Deploy Preview for blobs-js ready!

Name	Link
🔨 Latest commit	`4fe2323`
🔍 Latest deploy log	https://app.netlify.com/sites/blobs-js/deploys/654cb01bc8542400082f3fda
😎 Deploy Preview	https://deploy-preview-96--blobs-js.netlify.app
📱 Preview on mobile	Toggle QR Code... QR Code Use your smartphone camera to open QR code link.