-
Notifications
You must be signed in to change notification settings - Fork 3
feat: load context from global variable #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@github-actions
github-actions
bot
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Nov 2, 2023
minivan
minivan
approved these changes
Nov 2, 2023
Skn0tt
Skn0tt
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Currently, the client is loading the context from an environment variable called
NETLIFY_BLOBS_CONTEXT
, so both serverless functions and edge functions need to set the updated context on each request, by settingprocess.env.NETLIFY_BLOBS_CONTEXT
in Node.js and by callingDeno.env.set()
in Deno.I wanted to see if there was any performance penalty in calling
Deno.env.set()
versus just setting a global variable, so I ran this benchmark and ran it a few times:These are the results I'm seeing:
I'm consistently seeing the environment variable set being ~20x slower than the global variable equivalent. In an environment where every millisecond counts, I think we should try to optimise this as best as we can.
So in this PR I'm making it possible for the client to read the context from a
netlifyBlobsContext
environment variable before trying to read it from an environment variable.