-
Notifications
You must be signed in to change notification settings - Fork 3
chore: cleanup unused dependency #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
341ce4d to
66b1c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow. If we're using esbuild to bundle the library before publishing, shouldn't it be a devDependency? Some context in the PR description would help.
I don't follow. If we're using esbuild to bundle the library before publishing, shouldn't it be a devDependency? Some context in the PR description would help.
sorry updated the description. We've removed esbuild in #59
@lukasholzer Can you get this one across the finish line? Seems like tests are failing.
Uh oh!
There was an error while loading. Please reload this page.
π Thanks for sending this pull request! π
As we removed esbuild in #59 and replaced it with
tsupβ a package bundler that emit types in the correct format as well, I forgot to remove the dev dependency on esbuild.This PR is a follow up cleaning up the unused dependency.