-
Notifications
You must be signed in to change notification settings - Fork 3
fix: revert workaround for CloudFront incorrectly returning a 403 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@lukasholzer
lukasholzer
force-pushed
the
revert-47-fix/dont-throw-on-403-status-code
branch
from
September 21, 2023 14:59
e7448cc
to
2898d00
Compare
@eduardoboucas
eduardoboucas
changed the title
(削除) Revert "fix: workaround for a cloudfront issue where it throws on a 403" (削除ここまで)
(追記) fix: revert workaround for CloudFront incorrectly returning a 403 (追記ここまで)
Sep 22, 2023
eduardoboucas
eduardoboucas
approved these changes
Sep 22, 2023
@github-actions
github-actions
bot
added
the
type: bug
code to address defects in shipped code
label
Sep 22, 2023
@lukasholzer
lukasholzer
deleted the
revert-47-fix/dont-throw-on-403-status-code
branch
September 22, 2023 10:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Reverts #47 as this one is fixed https://github.com/netlify/pod-dev-foundations/issues/592