-
Notifications
You must be signed in to change notification settings - Fork 3
fix: send content-length with streams #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@github-actions
github-actions
bot
added
the
type: bug
code to address defects in shipped code
label
Jul 26, 2023
@ascorbic
ascorbic
force-pushed
the
stream-content-length
branch
from
July 26, 2023 20:08
7372af9 to
2f46003
Compare
Doesn't solve the problem, so closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 throws an error if transfer encoding is chunked. This happens if a stream is sent with no content-length. This PR adds a new
contentLengthoption which is required when setting a stream. I've set the types up so it should enforce this, but it also includes runtime checks for the same. I've not actually tested if this fixes the problem yet