Skip to content

feat: support named deploy-scoped stores #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

eduardoboucas merged 2 commits into main from feat/deploy-named-stores

Jul 1, 2024

Merged

feat: support named deploy-scoped stores #181

eduardoboucas merged 2 commits into main from feat/deploy-named-stores

Jul 1, 2024

Conversation

Copy link

Member

@eduardoboucas eduardoboucas commented Jul 1, 2024

Part of https://linear.app/netlify/issue/ADN-97/extend-getdeploystore-to-accept-a-name.


 feat: support named deploy-scoped stores

0f74334

@eduardoboucas eduardoboucas requested a review from a team as a code owner

July 1, 2024 12:37

@github-actions github-actions bot added the type: feature label

@netlify Netlify

Copy link

netlify bot commented Jul 1, 2024 •

edited

Loading

✅ Deploy Preview for blobs-js ready!

Name	Link
🔨 Latest commit	`b54810f`
🔍 Latest deploy log	https://app.netlify.com/sites/blobs-js/deploys/6682d3811f52150008597467
😎 Deploy Preview	https://deploy-preview-181--blobs-js.netlify.app
📱 Preview on mobile	Toggle QR Code... QR Code Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

paulo reviewed

View reviewed changes

src/main.test.ts

env.NETLIFY_BLOBS_CONTEXT = Buffer.from(JSON.stringify(context)).toString('base64')

const deployStore = getDeployStore(mockStoreName)

Copy link

@paulo paulo Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these 2 test names switched?

Copy link

Member Author

@eduardoboucas eduardoboucas Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?! The idea that I would do such a silly mistake is ludicrous.

(Yes. Yes, they were. b54810f)


 chore: fix test names

b54810f

paulo approved these changes

View reviewed changes

@eduardoboucas eduardoboucas merged commit 7b24ef8 into main

@eduardoboucas eduardoboucas deleted the feat/deploy-named-stores branch

July 1, 2024 16:11

@token-generator-app token-generator-app bot mentioned this pull request

chore(main): release 7.4.0 #182

Merged

@mrstork mrstork mentioned this pull request

chore(deps): update dependency @netlify/blobs to ^7.4.0 opennextjs/opennextjs-netlify#2525

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants

@eduardoboucas @paulo