Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat!: move server to sub-module export #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eduardoboucas merged 2 commits into main from feat/server-sub-module
Mar 6, 2024
Merged

Conversation

Copy link
Member

@eduardoboucas eduardoboucas commented Mar 6, 2024

Which problem is this pull request solving?

Moves the local server to a sub-module export. This means that the way the BlobsServer class is imported has changed:

-import { BlobsServer } from "@netlify/blobs"
+import { BlobsServer } from "@netlify/blobs/server"
const server = new BlobsServer()
 

BREAKING CHANGE: The `BlobsServer` class is no longer available in the main package export
@eduardoboucas eduardoboucas requested a review from a team as a code owner March 6, 2024 16:41
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024 •
edited
Loading

✅ Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 5b34e03
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/65e89ea9463e61000888d5c1
😎 Deploy Preview https://deploy-preview-155--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

ascorbic commented Mar 6, 2024

It would be good to add a server.d.ts in the root that just re-exports from dist. Otherwise sites that use moduleResolution: node will have trouble resolving the types.

Copy link
Member Author

It would be good to add a server.d.ts in the root that just re-exports from dist. Otherwise sites that use moduleResolution: node will have trouble resolving the types.

Good call. Done in 5b34e03.

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As an aside, I am a big fan of using @arethetypeswrong/cli and publint in CI. The former would have complained about the missing root subpath export.

eduardoboucas reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ascorbic ascorbic ascorbic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /