-
Notifications
You must be signed in to change notification settings - Fork 3
fix: disallow empty key #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also make this part of the check on line 318 and adjust the message to something like:
Blob key must be a sequence of Unicode characters whose UTF-8 encoding is between 1 and 600 bytes long.
Just an idea, no strong preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nifty - but if I were debugging this exception, I think i'd be way more confused by the words "Unicode" and "UTF-8" than necessary. Gonna keep it like it is!
Disallows
""as key. This is not a breaking change, because before we had a bug whereget("")would show the result oflist()- so this didn't work in the first place.Resolves https://linear.app/netlify/issue/COM-283/blobs-get-shows-unintended-api-response.