Skip to content

fix: fix metadata in local server #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

eduardoboucas merged 1 commit into main from fix/metadata-delete

Nov 14, 2023

Merged

fix: fix metadata in local server #112

eduardoboucas merged 1 commit into main from fix/metadata-delete

Nov 14, 2023

Conversation

Copy link

Member

@eduardoboucas eduardoboucas commented Nov 14, 2023

Which problem is this pull request solving?

Fixes a couple of issues with the local server:

When we deleted an entry, we were not deleting its metadata
When we're in API access, a HEAD request should return the metadata right away and not a signed URL
When getting the metadata for a key that doesn't exist, we were returning 500 instead of 404
When listing an empty store, we were returning 500 instead of a 200 with no entries


 fix: fix metadata in local server

8f9aadf

@eduardoboucas eduardoboucas requested a review from a team as a code owner

November 14, 2023 15:49

@netlify Netlify

Copy link

netlify bot commented Nov 14, 2023 •

edited

Loading

✅ Deploy Preview for blobs-js ready!

Name	Link
🔨 Latest commit	`8f9aadf`
🔍 Latest deploy log	https://app.netlify.com/sites/blobs-js/deploys/65539718bbf4960007a1b42c
😎 Deploy Preview	https://deploy-preview-112--blobs-js.netlify.app
📱 Preview on mobile	Toggle QR Code... QR Code Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug label

eduardoboucas commented

View reviewed changes

src/server.test.ts

expect(parachutesSongs2.directories).toEqual([])

})

test('Supports the API access interface', async () => {

Copy link

Member Author

@eduardoboucas eduardoboucas Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have one single test with the same set of assertions testing both the API and Edge interfaces.

ascorbic approved these changes

View reviewed changes

Copy link

Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@eduardoboucas eduardoboucas merged commit 9646519 into main

@eduardoboucas eduardoboucas deleted the fix/metadata-delete branch

November 14, 2023 15:55

@token-generator-app token-generator-app bot mentioned this pull request

chore(main): release 6.2.0 #111

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants

@eduardoboucas @ascorbic