Skip to content

docs: clarify lifecycle events #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

TheCoreMan wants to merge 1 commit into nestjs:master

from TheCoreMan:patch-1

Open

docs: clarify lifecycle events #3281

Changes from all commits

Commits

Show all changes

Select commit

docs: clarify lifecycle events

TheCoreMan Jun 15, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

2 changes: 1 addition & 1 deletion content/fundamentals/lifecycle-events.md

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,7 +18,7 @@ In the following table, `onModuleDestroy`, `beforeApplicationShutdown` and `onAp

		\| Lifecycle hook method \| Lifecycle event triggering the hook method call \|
		\| ------------------------------- \| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- \|
	\| `onModuleInit()` \| Called once the host module's dependencies have been resolved. \|
	\| `onModuleInit()` \| Called once the host module's dependencies have been resolved. "Once" meaning called AFTER the host module's dependencies have been resolved, but not necessarily one time only. \|
Copy link Member @kamilmysliwiec kamilmysliwiec Jun 16, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Not sure if I'm following. This hook is called one time only per each provider that implements it. The change you suggested ("not necessarily one time only") may lead someone to think that it might be called several times for the same provider (which isn't true). Correct me if I'm wrong micalevisk reacted with thumbs up emoji Copy link @magoogli magoogli Jul 28, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @kamilmysliwiec I have had the same issue - I have a situation where the hook is called twice for the same provider. This scenario is easily reproduced. See https://github.com/magoogli/nest-js for a minimal repo. Is this expected behaviour? My onModuleInit hook is called twice for the same provider ( although the constructor is only called once ). This is very confusing and frustrating. Any help would be greatly appreciated.
		\| `onApplicationBootstrap()` \| Called once all modules have been initialized, but before listening for connections. \|
		\| `onModuleDestroy()`\* \| Called after a termination signal (e.g., `SIGTERM`) has been received. \|
		\| `beforeApplicationShutdown()`\* \| Called after all `onModuleDestroy()` handlers have completed (Promises resolved or rejected);<br />once complete (Promises resolved or rejected), all existing connections will be closed (`app.close()` called). \|
Expand Down