-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: add a new page for advanced topics #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
50cff96 to
37abe1f
Compare
Currently only discusses how `@Injectable()` works. We can add more in as time goes.
37abe1f to
9c2f0c5
Compare
carnesen
commented
Jan 23, 2023
I appreciate this MR. I was trying to figure out in my own code how Nest.js was injecting into my class when I had accidentally omitted the "Injectable" decorator. I found my answer here, "by technicality [having @Inject on a contructor param] does enough to make TypeScript emit all the same metadata".
I started using Helix as an editor which doesn't directly support soft line wraps (it does now but it didn't) and got in the habit of keeping my markdown files to around 80 characters per line. This also leads to easier times in code reviews finding incorrect words and highlighting them due to only a single line being highlighted instead of an entire paragraph
Hi @jmcdo29, 👋🏻
I read the article you wrote on Trilon's blog: https://trilon.io/blog/nestjs-metadata-deep-dive 🔥, very interesting! Great!
While reading this article, this PR came to my mind, do you think we can merge this PR or do you still need to add something?
I think it is very useful to add it to the NestJS documentation.
@kamilmysliwiec when you find some time can you take a look at it so we can see if we can add it to the documentation ?
I wonder if 'internal' instead of 'advanced' would be better 🤔
because we can have advanced stuff for user-facing concepts
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There's no deep dive/advanced docs that could help some people understand why things are the way they are.
What is the new behavior?
There's a new page that discusses how
@Injectable()works and what it's really doing.Does this PR introduce a breaking change?
Other information