-
Notifications
You must be signed in to change notification settings - Fork 2k
docs(openapi): Add docs to throw different exceptions under the same ... #2198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you add a hint at the end to tell from where refs is imported? I didn't find any reference to this utility in the docs yet
Like this one
@AxelDavid45
AxelDavid45
force-pushed
the
patch-2
branch
from
February 5, 2022 18:50
c51f16c to
31c8dc4
Compare
@micalevisk Done, is it OK?
@Injectable() export class CatController { @ApiExtraModels(BadAppCodeException, BadEmailException) @ApiBadRequestResponse({ schema: { oneOf: refs(BadAppCodeException, BadEmailException), }, }) multipleErrorsResponse() { ... } }
some indentation
@AxelDavid45
AxelDavid45
force-pushed
the
patch-2
branch
from
February 5, 2022 21:07
31c8dc4 to
fe4840f
Compare
@AxelDavid45
AxelDavid45
force-pushed
the
patch-2
branch
from
February 5, 2022 21:08
fe4840f to
b00fd58
Compare
@micalevisk Added indentation
micalevisk
micalevisk
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...http code
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
I think it's worthy to add this part to the docs because the decorator
@ApiExtraModels()doesn't have an concrete example of its implementation.Does this PR introduce a breaking change?
Other information