Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: Issue on iPhone 11 not show backdrop full size #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rigor789 merged 2 commits into nativescript-vue:master from gravataLonga:master
Jun 21, 2020
Merged

FIX: Issue on iPhone 11 not show backdrop full size #12

rigor789 merged 2 commits into nativescript-vue:master from gravataLonga:master
Jun 21, 2020

Conversation

Copy link
Contributor

@gravataLonga gravataLonga commented Jun 21, 2020
edited
Loading

Hello @rigor789 can you please accept my pull request, i found an issue on iPhone 11 backdrop isn't full size, you can see here:

IPHONE 11 (BUG)
Screenshot 2020年06月21日 at 14 10 58

IPHONE 8 (GOOD)
Screenshot 2020年06月21日 at 14 40 53

Please accept my pull request as soon as possible, because for me it's importante to be resolve. :(

After the fix, i can now see correct backdrop:
Screenshot 2020年06月21日 at 14 42 19

Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Copy link
Contributor Author

@gravataLonga gravataLonga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry

@rigor789 rigor789 merged commit d21c9ae into nativescript-vue:master Jun 21, 2020
Copy link
Contributor Author

gravataLonga commented Jun 21, 2020
edited
Loading

@rigor789 Isn't working yet, i think you need to do an extra step in order to get the latest update, i'm not expert on npm modules
On my machine it's said is in latest version,
Screenshot 2020年06月21日 at 16 53 34

but i can't update to last version in order to get this update. Think you need to dump a new version..

Using GIT you can do that with:

git tag -a "0.0.3" -m "New release"

then pushed to master branch:
git push origin master --tags

but to npm to pick up this new update i don't know how.

Copy link
Member

I will push an update to npm in a bit, it's a manual process...

gravataLonga reacted with hooray emoji

Copy link
Contributor Author

gravataLonga commented Jun 21, 2020
edited
Loading

@rigor789 thank you and sorry about to "much" spam. :( I'm only try to help, sorry about that.

Copy link
Member

Released just now as 0.0.3

Copy link
Contributor Author

Omg 😮 thank! I will try in a bit

gravataLonga reacted with hooray emoji

Copy link
Contributor Author

@rigor789 It's working now, thank for your fast response! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /