Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

using sh to make alpine images work #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrApe wants to merge 1 commit into nanoninja:master from MrApe:master
Closed

Conversation

Copy link

@MrApe MrApe commented Oct 9, 2017

Alpine does not come with bash installed, so "command" should use sh to be compatible with the alpine version of nginx images.

Alpine does not come with bash installed, so "command" should use sh to be compatible with the alpine version of nginx images.
Copy link
Owner

Hello @MrApe ,

I do not have time to look at this but I will analyze your request as soon as possible.

Thanks for your feedback.

Copy link
Owner

@MrApe

I just looked at your sources and maybe you have encountered errors about the shell to use? I did not have any worries about that.

It is also the bash which is used in the documentation of Nginx.

Can you give me more information about this choice please?

Copy link
Author

MrApe commented Oct 12, 2017 via email

Hi. If you use the alpine version of the container, there is no bash installed. Best Regards, Jonas Am 11. Okt. 2017, 16:40 +0200 schrieb Nanoninja <notifications@github.com>:
...
@MrApe I just looked at your sources and maybe you have encountered errors about the shell to use? I did not have any worries about that. It is also the bash which is used in the documentation of Nginx. Can you give me more information about this choice please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Copy link
Owner

nanoninja commented Dec 19, 2017
edited
Loading

Hi @MrApe,

I come back after a while, but as there was an error in the test, I have not integrated your pull request.

You're right about the fact that it generates an error if I go through the bash and it was the case because I did not use the image nginx: alpine

The changes will be made in the next release.

Thanks for your feedback.

Vincent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /