-
Notifications
You must be signed in to change notification settings - Fork 12.9k
fix(signal): stage inbound image attachments as base64 so the container can read them#2695
Open
cfis wants to merge 1 commit into
Open
fix(signal): stage inbound image attachments as base64 so the container can read them #2695cfis wants to merge 1 commit into
cfis wants to merge 1 commit into
Conversation
The adapter emitted a host filesystem path (signal-cli's attachments dir) for inbound images. The agent runs in a container that doesn't mount that path, so it could never read the image. Read the bytes and pass them as base64 `data` instead — session-manager.extractAttachmentFiles stages those into the session's mounted inbox/ and rewrites to a container-readable localPath, which the formatter surfaces as [image: <name> — saved to /workspace/inbox/...].
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Signal adapter surfaces inbound images by emitting signal-cli's host attachment path (
<signalDataDir>/attachments/<id>). The agent runs in a container that doesn't mount that path, so it can never read an image sent over Signal — the agent just gets an unreadable path.Fix: read the attachment bytes and pass them as base64
data. The host'ssession-manager.extractAttachmentFilesalready stages attachments carryingdatainto the session's mountedinbox/and rewrites them to a container-readablelocalPath, which the agent-runner formatter surfaces as[image: <name> — saved to /workspace/inbox/...]. This matches how inbound attachments reach the container on other channels. Also drops the now-misleading host-path[Image: <path>]text line.How it was tested: updated the inbound-image unit test to assert base64
datais forwarded (full Signal suite passes, 37/37). Verified end-to-end on a live install — an image sent over Signal now stages into the inbox and the agent reads and describes it.🤖 Generated with Claude Code