-
Notifications
You must be signed in to change notification settings - Fork 345
Add UseProcedureCache option and documentation. Fixes #1175 #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UseProcedureCache option and documentation. Fixes #1175 #1535
Conversation
Signed-off-by: tarasevichvlad <type.v@mail.ru>
The connection string changes look fine.
I think the change to FillAsync
isn't appropriate, as we do actually want CachedProcedure
information for AlignParamsWithDb
later on. Instead, we might want to make ConnectionPool.GetProcedureCache
return null
if procedure caching is disabled. But even then we wouldn't want to cache the procedure (even on the MySqlConnection) beyond the lifetime of the ExecuteXyz
call. (And we would also need to update logging so it doesn't log incorrect messages about what is happening.)
Sorry I don't have more specific guidance yet; I haven't looked into the details of how to solve this problem.
@bgrainger
I took a closer look at the places where parameter caching is used for procedures and made some changes.
If you have time, please look at additional edits to support this feature.
@bgrainger What do you think about this changes. This is implementation for second idea in #1175 issue.
Currently without tests.