Bump psalm to v4.9.2 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

simPod wants to merge 1 commit into myclabs:master

from simPod:psalm

Open

Bump psalm to v4.9.2 #151

simPod wants to merge 1 commit into myclabs:master from simPod:psalm

Conversation

simPod

Copy link

Contributor

@simPod simPod commented Aug 3, 2021 •

edited

Loading

Lock to v4.9 otherwise it bumps automatically, finds new issues and builds start failing without any change in this lib
Fix some psalm issues
Enable findUnusedPsalmSuppress
Resolves Build Failing due to psalm update #130
Resolves Removing unnecessary psalm suppress docblock #149

@simPod simPod force-pushed the psalm branch from eb30c4d to 67e342c Compare

August 3, 2021 08:45

@simPod simPod marked this pull request as ready for review

August 3, 2021 08:45

@mnapoli

Copy link

Member

mnapoli commented Aug 3, 2021

Thanks!

I'll wait for a 3rd party approbation. I keep merging Psalm PRs on this project, and it seems half of them breaks something for someone ^^ I don't know enough Psalm to validate the annotation changes honestly.

simPod

simPod commented

Aug 3, 2021

View reviewed changes

Copy link

Contributor Author

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added explanatory comments just fyi

src/Enum.php

/**

* @psalm-pure

* @psalm-suppress InvalidCast

Copy link

Contributor Author

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused

src/Enum.php

* Returns all possible values as an array

* @psalm-pure

* @psalm-suppress ImpureStaticProperty

Copy link

Contributor Author

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused

src/Enum.php

/** @psalm-var T $value */

foreach (static::toArray() as $key => $value) {

/** @psalm-suppress UnsafeGenericInstantiation */

Copy link

Contributor Author

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO true, generic params may indeed be constrained in children

src/Enum.php

$message = "No static method or enum constant '$name' in class " . static::class;

throw new \BadMethodCallException($message);

}

/** @psalm-suppress UnsafeGenericInstantiation */

Copy link

Contributor Author

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO true, generic params may indeed be constrained in children

@simPod


 Bump psalm to v4.9.2

b0bd8e2

- Lock to v4.9 otherwise it bumps automatically, finds new issues and builds start failing without any change in this lib
- fix some psalm issues
- enable `findUnusedPsalmSuppress`

@simPod simPod force-pushed the psalm branch from 67e342c to b0bd8e2 Compare

August 24, 2021 13:06

@thedotedge

Copy link

thedotedge commented Apr 5, 2022

hi, any plans to merge it?

Labels

None yet

3 participants

@simPod @mnapoli @thedotedge

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bump psalm to v4.9.2 #151

Are you sure you want to change the base?

Bump psalm to v4.9.2 #151

Uh oh!

Conversation

@simPod simPod commented Aug 3, 2021 •

edited

Loading

Uh oh!

Uh oh!

mnapoli commented Aug 3, 2021

Uh oh!

@simPod simPod left a comment

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

thedotedge commented Apr 5, 2022

Uh oh!

Uh oh!

Uh oh!

Bump psalm to v4.9.2 #151

Are you sure you want to change the base?

Bump psalm to v4.9.2 #151

Uh oh!

Conversation

@simPod simPod commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mnapoli commented Aug 3, 2021

Uh oh!

@simPod simPod left a comment

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

@simPod simPod Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

thedotedge commented Apr 5, 2022

Uh oh!

Uh oh!

@simPod simPod commented Aug 3, 2021 •

edited

Loading