-
-
Notifications
You must be signed in to change notification settings - Fork 176
admin2: Add GUI panel for mute#684
admin2: Add GUI panel for mute #684omar-o22 wants to merge 12 commits intomultitheftauto:master from
Conversation
@ArranTuna
ArranTuna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you close admin panel while the mute GUI is open, it doesn't close, and then after that I clicked close (with console) and GUI won't close.
ArranTuna
commented
Sep 18, 2025
Also it's not very user friendly if you want to set a custom time, say 1 month, right now you'd have to open calculator to see how many seconds are in a month. Nobody wants to mute someone for less than 1 minute anyway, so at least the box should be minutes not seconds, and or have different boxes, so you can put amount of seconds, minutes, hours, or days.
Fernando-A-Rocha
commented
Sep 18, 2025
I agree mute duration should be minutes by default, but also allow other units of measurement for custom needs (seconds, hours..)
omar-o22
commented
Sep 18, 2025
Alright, I’ll start working on the fix tonight.
omar-o22
commented
Sep 18, 2025
If you close admin panel while the mute GUI is open, it doesn't close, and then after that I clicked close (with console) and GUI won't close.
It works correctly for me. can u explain more what u did?
ArranTuna
commented
Sep 18, 2025
You're right, what you have to do is, press mute twice, then close the panel and you're stuck with a second panel. So basically when you click mute, don't make another GUI if one already exists.
@jlillis
jlillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this quite resolves #108, as it mutes are not able to persist if the server or resource restarts. There will also need to be a new tab to view, modify, and delete existing mutes.
I don't think this quite resolves #108, as it mutes are not able to persist if the server or resource restarts. There will also need to be a new tab to view, modify, and delete existing mutes.
I don't know where to save the data because admin2 saves some data in conf/***.xml and some in admin.db too
So should I save data in admin.db or create a new xml file?
ArranTuna
commented
Sep 19, 2025
You're right, what you have to do is, press mute twice, then close the panel and you're stuck with a second panel. So basically when you click mute, don't make another GUI if one already exists.
I don't know where to save the data because admin2 saves some data in conf/***.xml and some in admin.db too So should I save data in admin.db or create a new xml file?
Use this existing connection to admin.db:
connection = dbConnect("sqlite", "admin.db"),
And use the dbExec and dbQuery functions and use dbQuery call back function feature.
Thanks for the review. I've included everything in the last commit,
I implemented mute duration in seconds, same as bans, since I reused the ban code as a base,
I'll create another PR to update ban dialog (adds radio boxes seconds, minutes, etc...) And update mute/ban details style soon
ArranTuna
commented
Sep 22, 2025
I added a mute on myself and don't see it in mutes tab and refresh button is disabled?
omar-o22
commented
Sep 22, 2025
I added a mute on myself and don't see it in mutes tab and refresh button is disabled?
You need to update your acl.xml because I added some new access
<right name="general.tab_mutes" access="true"></right> <right name="command.listmute" access="true"></right>
xLive
commented
Sep 22, 2025
I added a mute on myself and don't see it in mutes tab and refresh button is disabled?
You need to update your acl.xml because I added some new access
<right name="general.tab_mutes" access="true"></right> <right name="command.listmute" access="true"></right>
New ACL rights need to be added to ACL.xml, otherwise the admin2 resource won’t add them with the rest of the rights on start.
omar-o22
commented
Sep 22, 2025
I added a mute on myself and don't see it in mutes tab and refresh button is disabled?
You need to update your acl.xml because I added some new access
<right name="general.tab_mutes" access="true"></right> <right name="command.listmute" access="true"></right>New ACL rights need to be added to ACL.xml, otherwise the admin2 resource won’t add them with the rest of the rights on start.
Ty, I thought I should make a PR in mtasa-blue to update the ACL, but I didn’t see this file.
@Lpsd
Lpsd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As mentioned in Discord, may be nice to have an option/checkbox for muting player voice too, if that's possible.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Preview:
imageEdited
I did a mention for issue 106 by mistake