-
-
Notifications
You must be signed in to change notification settings - Fork 176
Merged
Conversation
Member
qaisjp
commented
Nov 10, 2020
CODEOWNERS: I think we can remove lil_Toady and cazomino05 from CODEOWNERS. That would leave me being automatically assigned to admin2 PRs. If you're interested in driving admin2 forward, feel free to add yourself to it.
Coding style
- I think we should leave Coding style for a separate PR just so that the rest of the changes in this PR don't get stuck behind thinking about specific style decisions.
- IMO it's definitely worth at least discussing and documenting the ideal state, even if we can't autoformat or enforce it.
- I think this repository should be a gold standard for what MTA resources look like (and it isn't that right now).
- There's some additional context here about mass code formatting: Add .editorconfig file #247 (review) .
Contributor
Author
jlillis
commented
Nov 10, 2020
You're right, I think I'll open up a discussion of coding style in a separate issue and leave this as it is for now.
I wasn't aware that CODEOWNERS had that functionality. I'll update it as you described.
qaisjp
qaisjp
approved these changes
Nov 10, 2020
qaisjp
qaisjp
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
When merged this repo will add some miscellaneous repo files in the .github directory, including:
It also updates the security_report template to provide updated guidance on reporting vulnerabilities.