-
Notifications
You must be signed in to change notification settings - Fork 171
remove WebAssembly stuff because it is not much faster than pureJs #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gfx
gfx
force-pushed
the
remove_wasm
branch
from
December 27, 2019 01:00
de7b1f1 to
a984d72
Compare
Codecov Report
@@ Coverage Diff @@ ## master #95 +/- ## ========================================== + Coverage 98.33% 98.55% +0.21% ========================================== Files 16 15 -1 Lines 961 898 -63 Branches 196 189 -7 ========================================== - Hits 945 885 -60 + Misses 16 13 -3
Continue to review full report at Codecov.
|
@gfx
gfx
force-pushed
the
remove_wasm
branch
from
December 27, 2019 01:11
a984d72 to
9d034fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly implementation (#26) was an experiment, which has proved that Wasm for UTF-8 encode/decode is not much faster than pureJS. Instead, the code is complex and hard to maintain.
I've decided to remove the Wasm impl to keep the code clean and easy to maintain.