Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add decodeStream #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeyzenchenko merged 5 commits into master from decodeStream
May 30, 2019
Merged

Add decodeStream #46

sergeyzenchenko merged 5 commits into master from decodeStream
May 30, 2019

Conversation

Copy link
Collaborator

@sergeyzenchenko sergeyzenchenko commented May 30, 2019

No description provided.

src/Decoder.ts Outdated

try {
while (true) {
let result = this.decodeSync();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let result = this.decodeSync();
const result = this.decodeSync();

for await (let item of decoder.decodeArrayStream(stream)) {
yield item;
}
return decoder.decodeArrayStream(stream);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


const result = [];

for await (let item of decodeStream(createStream())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for await (let item of decodeStream(createStream())) {
for await (const item of decodeStream(createStream())) {

Copy link
Collaborator Author

fixed @gfx

Copy link

codecov-io commented May 30, 2019
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@580e798). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@ Coverage Diff @@
## master #46 +/- ##
=========================================
 Coverage ? 93.45% 
=========================================
 Files ? 15 
 Lines ? 840 
 Branches ? 175 
=========================================
 Hits ? 785 
 Misses ? 29 
 Partials ? 26
Impacted Files Coverage Δ
src/decodeAsync.ts 100% <100%> (ø)
src/Decoder.ts 95.88% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580e798...ad1d0d0. Read the comment docs.

Copy link
Member

@gfx gfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@gfx gfx mentioned this pull request May 30, 2019
@sergeyzenchenko sergeyzenchenko deleted the decodeStream branch May 30, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfx gfx gfx approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /