-
Notifications
You must be signed in to change notification settings - Fork 171
Export Decoder and Encoder for direct usage #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gfx what do you think about it?
Codecov Report
@@ Coverage Diff @@ ## master #45 +/- ## ========================================== + Coverage 91.46% 91.48% +0.02% ========================================== Files 14 14 Lines 808 810 +2 Branches 170 170 ========================================== + Hits 739 741 +2 Misses 49 49 Partials 20 20
Continue to review full report at Codecov.
|
The reason why they are not exported is just their interfaces are not stable yet and there are no use cases suggested, but if you need them, it's time to export them.
LGTM
thanks!
In some cases Decoder/Encoder need to be used directly without wrapper functions. For example in our project we have custom format that consist of
binary with:
and this structure can't be parsed or formed using regular functions, but it can be easily done by using Decoder/Encoder directly.